cmake: fix backwards compatibility logic #6271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forgot about this one as well. It was discussed already some time ago, so |
|
tested the patch, symlink is present and no headers were overwritten |
jenkins4kodi
added a commit
that referenced
this pull request
Jan 26, 2015
|
Thanks for the feedback @garbear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a comment from @garbear at https://github.com/garbear/peripheral.joystick/tree/cmake I realized that I never PR'ed this fix for the backwards compatibility logic in our cmake buildsystem which is intended to take care of being able to still build binary addons that use "xbmc" include paths instead of "kodi" ones.
The problem is that the logic overwrites the actual "kodi" header files with ones that only contain a warning and a forwarded include if the buildsystem is set up so that the "xbmc" include directory is a symlink to the "kodi" include directory.
This changes the logic to only write the forwarding header files if they don't already exist (which is the case when using a symlink).