Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard Layouts] Add missing characters in German and Greek keyboards #6318

Merged
merged 2 commits into from Mar 25, 2015
Merged

[Keyboard Layouts] Add missing characters in German and Greek keyboards #6318

merged 2 commits into from Mar 25, 2015

Conversation

hudokkow
Copy link
Member

@hudokkow hudokkow commented Feb 1, 2015

@da-anda
Copy link
Member

da-anda commented Feb 2, 2015

thanks. I just realized that § is missing in German and many latin keyboard layouts as well (just as on iOS and Android keyboards - so better don't use this character in passwords you have to enter in a smartphone ;) )

@hudokkow
Copy link
Member Author

hudokkow commented Feb 2, 2015

Updated.
@da-anda, do you know other latin keyboards that use the "§" so I can add it and make a new PR?
I'm using a Portuguese keyboard and that character doesn't even exist.

@Mettbrot
Copy link
Contributor

Mettbrot commented Feb 2, 2015

Hey! Just saw that the € is missing too. (maybe next to $)
Don't you think it would be better to show the ß on the 'normal' page right next to 0 for example?

@da-anda
Copy link
Member

da-anda commented Feb 3, 2015

@hudokkow according to wikipedia (https://en.wikipedia.org/wiki/Keyboard_layout) "§" is also used on greek keyboard layout.

@Mettbrot good catch with the €

@hudokkow hudokkow changed the title [Keyboard Layouts] Add missing "ß" in German keyboard [Keyboard Layouts] Add missing characters in German and Greek keyboards Feb 3, 2015
@hudokkow
Copy link
Member Author

hudokkow commented Feb 3, 2015

@da-anda updated.

@tamland
Copy link
Member

tamland commented Feb 3, 2015

€ is a symbol so why shouldn't that be on the symbol page? Perhaps it's time to agree on a standard here because I see symbols missing on several layout. So either follow the actual keyboard layout or create one with all symbols.

@MartijnKaijser
Copy link
Member

€ doesn't belong on the letter part imo and should be at the symbol one.

@hudokkow
Copy link
Member Author

hudokkow commented Feb 3, 2015

OK. Lets agree on a standard and go from there.
I'll redo the commits as soon as we have a few more opinions.

@Montellese
Copy link
Member

I'd follow the actual keyboard layouts as much as possible because that's what users are familiar with. Any "special" characters that need a modifier key on a normal keyboard should go into symbols.
I'm pretty sure that looking at the android/ios keyboard layout/approach won't hurt either.

@Mettbrot
Copy link
Contributor

Mettbrot commented Feb 3, 2015

@hudokkow I only meant the ß on the letter page. € right next to $ is fine :)
Also µ next to m seems strange. I don't know why its there on some keyboards. It's not like we use greek letters that much in german..

@hudokkow hudokkow force-pushed the german_keyboard branch 5 times, most recently from 976389f to 4188ef9 Compare March 7, 2015 10:13
@da-anda
Copy link
Member

da-anda commented Mar 16, 2015

@hudokkow mind rebasing this as it can't be merged atm. Thanks.

@hudokkow
Copy link
Member Author

@da-anda, a bit late but done.

da-anda
da-anda reviewed Mar 24, 2015
View reviewed changes
system/keyboardlayouts/german.xml
<row>qwertzuiopü</row>
<row>asdfghjklöä</row>
<row>yxcvbnm</row>
<row>yxcvbnmμ</row>

This comment was marked as spam.

Sign in to view

@hudokkow
Copy link
Member Author

Done.

da-anda added a commit that referenced this pull request Mar 25, 2015
@da-anda
Merge pull request #6318 from hudokkow/german_keyboard
dd4fd13 
[Keyboard Layouts] Add missing characters in German and Greek keyboards
@da-anda da-anda merged commit dd4fd13 into xbmc:master Mar 25, 2015
@hudokkow hudokkow deleted the german_keyboard branch March 29, 2015 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Isengard 15.0-alpha2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hudokkow @da-anda @Mettbrot @tamland @MartijnKaijser @Montellese