Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] adds new info label Player.SeekStepSize #6387

Merged
merged 2 commits into from
Feb 10, 2015
Merged

[gui] adds new info label Player.SeekStepSize #6387

merged 2 commits into from
Feb 10, 2015

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Feb 9, 2015

This will updates the seek offset in CGUIInfoManager for every call to CSeekHandler::Seek() if using smart seeking which gives us the possibility to output the seek step size before the seek is processed.

@da-anda mind taking a look .. might we use a different GUI info var as Player.SeekOffset e.g. Player.SeekStepSize?

@xhaggi xhaggi added the Type: Improvement non-breaking change which improves existing functionality label Feb 9, 2015
@xhaggi
Copy link
Member Author

xhaggi commented Feb 9, 2015

BTW should we do this for analog as well?

@da-anda
Copy link
Member

da-anda commented Feb 10, 2015

hmmm, a separate var might be nice, or at least a way for skins to differ between smart seeking and other seek methods, because I don't think the step size info is relevant with fixed seek steps. Also we have to think about simmulating the old behavior - when I do so I probably don't need to see a "+30 sec" info huge on screen while with smart seeking it's a necessity. So maybe some "seekMode" var?

@xhaggi
Copy link
Member Author

xhaggi commented Feb 10, 2015

@da-anda agree and I've added a new info label Player.SeekStepSize which holds the current seek step size if using smart step based skipping. It's currently displayed in Confluence just like the Player.SeekOffset label. IMO it's up to our skin devs to change the DialogSeekBar design ;)

da-anda
da-anda reviewed Feb 10, 2015
View reviewed changes
xbmc/utils/SeekHandler.cpp
@@ -141,7 +141,10 @@ void CSeekHandler::Seek(bool forward, float amount, float duration /* = 0 */, bo
if (g_infoManager.GetTotalPlayTime())
percentPerSecond = 100.0f / (float)g_infoManager.GetTotalPlayTime();

m_percent = m_percentPlayTime + percentPerSecond * GetSeekSeconds(forward);
int seekSeconds = GetSeekSeconds(forward);
g_infoManager.SetSeekStepSize(seekSeconds);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ronie
Copy link
Member

ronie commented Feb 10, 2015

skin changes are ok with me.

@xhaggi
Copy link
Member Author

xhaggi commented Feb 10, 2015

@da-anda any objections apart from your question?

@da-anda
Copy link
Member

da-anda commented Feb 10, 2015

@xhaggi - nope, good to go I think, haven't tested it though

@xhaggi
Copy link
Member Author

xhaggi commented Feb 10, 2015

jenkins build this please

@xhaggi xhaggi changed the title [gui] update seekoffset while using smart seek [gui] adds new info label Player.SeekStepSize Feb 10, 2015
xhaggi added a commit that referenced this pull request Feb 10, 2015
@xhaggi
Merge pull request #6387 from xhaggi/gui-update-seekoffset
4a5dd15 
[gui] adds new info label Player.SeekStepSize
@xhaggi xhaggi merged commit 4a5dd15 into xbmc:master Feb 10, 2015
@MartijnKaijser MartijnKaijser modified the milestone: I******* 15.0-alpha1 Feb 11, 2015
@xhaggi xhaggi deleted the gui-update-seekoffset branch February 23, 2015 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality
Projects
None yet
Milestone
Isengard 15.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xhaggi @da-anda @ronie @MartijnKaijser