Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale fixes (Helix) #6403

Merged
merged 9 commits into from
Feb 15, 2015
Merged

Locale fixes (Helix) #6403

merged 9 commits into from
Feb 15, 2015

Conversation

Karlson2k
Copy link
Member

Helix backport of #6402

@Karlson2k Karlson2k added Type: Fix non-breaking change which fixes an issue Helix labels Feb 11, 2015
@MartijnKaijser MartijnKaijser added this to the Helix 14.2 milestone Feb 11, 2015
Memphiz
Memphiz reviewed Feb 11, 2015
View reviewed changes
xbmc/win32/crts_caller.h
#define CALL_IN_CRTS(function,...) ::win32_utils::crts_caller::call_in_all_crts(BOOST_PP_STRINGIZE(function),&(function),##__VA_ARGS__)


#if 0 // remove autoindent

This comment was marked as spam.

Sign in to view

@MartijnKaijser MartijnKaijser mentioned this pull request Feb 13, 2015
Closed
@MartijnKaijser
Copy link
Member

@Karlson2k can you update this with the small rework you did for master?
Then we can get this in for the bugfix release and for master you can rework it a bit more.

@Karlson2k
Copy link
Member Author

Ofc.
Will do it tomorrow.

@Karlson2k
LangInfo: add m_locale and GetLocale() for current locale
ab7dfe8
@Karlson2k
StringUtils::AlphaNumericCompare(): do not use temporal locale object…
d8111f8 
… as use_facet() return only reference to facet stored in locale
@Karlson2k
[win32] Use _beginthreadex() instead of CreateThread() for better com…
e951fe9 
…patibility with CRT functions
@Karlson2k
[win32] Add win32/crts_caller for calling same function in all loaded…
eadcde1 
… CRTs

Conflicts:
	project/VS2010Express/XBMC.vcxproj.filters
@Karlson2k
[win32] WIN32Util: add SetThreadLocalLocale() for controlling thread …
f0075b3 
…local locale
@Karlson2k
[win32] Set thread local locale for main thread
063aeaf
@Karlson2k
[win32] Set thread local locale for started threads
60ddcaf
@Karlson2k
JSONVariantWriter::Write(): do no re-set locale if locale is already "C"
fefd1e0
@Karlson2k
[win32] JSONVariantWriter::Write(): use wide string version of setloc…
273282e 
…ale() to prevent crash on win32
@Karlson2k
Copy link
Member Author

Done.
Added one more missing commit (Karlson2k@e951fe9).

@MartijnKaijser
Copy link
Member

jenkins build this please

@Karlson2k
Copy link
Member Author

Jenkins is fine except iOS, where it's failed at git fetch.

MartijnKaijser added a commit that referenced this pull request Feb 15, 2015
@MartijnKaijser
Merge pull request #6403 from Karlson2k/w32_setloc_01h
1745b30 
Locale fixes (Helix)
@MartijnKaijser MartijnKaijser merged commit 1745b30 into xbmc:Helix Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Helix 14.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Karlson2k @MartijnKaijser @Memphiz