[keymap] show OSD when pressing SELECT on remotes in Visualisation #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… window to be consistent with videos
|
+1. Keyboard is already opening the OSD as well. |
|
@MartijnKaijser we might want to change it for 14.2 as well? |
|
no other comments or is nobody on git using music section ;) |
|
+1 from me as we should aim for more consistency between the music & videos sections. |
|
sure |
|
music, always +1 |
mkortstiege
added a commit
that referenced
this pull request
Feb 18, 2015
[keymap] show OSD when pressing SELECT on remotes in Visualisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the behavior when pressing SELECT/OK on remotes in FullscreenVideo and Visualisation window differs. While on FullscreenVideo you get the OSD menu you get some visualisation preset list for music. IMO this should be consistent and always trigger the OSD menu (do we really need a shortcut to visualisation presets on limited remotes?). This is especially useful when using CEC (which is using the remote keymap) with a limited set of buttons forwarded (like on LG TVs).