split addon gui for skin and binary addons

[FernetMenta]

see title

@MartijnKaijser @opdenkamp follow-up from our discussion

[FernetMenta]

jenkins build this please

[MartijnKaijser]

@FernetMenta same could be one for the PVR API/ABI versions to make it easier (other PR of course)

[opdenkamp]

looking good, +1
what do you mean @MartijnKaijser? the pvr one doesn't try to match to an api version used by python/skins?

[FernetMenta]

@opdenkamp he means the auto-generated version in addon.xml

[opdenkamp]

yeah found that out on irc, nice :)

[notspiff]

can you rationalize why you build these as separate objects ?

[opdenkamp]

they were already built as separate objects because guilib callbacks are not just for pvr add-ons, or am I misunderstanding the question?
the only difference is that the name changed and that we no longer try to match to the python API version used for skinning, which had nothing to do with these callbacks

[notspiff]

i know. it just gave a context..

they were built as separate objects to keep executable size down on xbox since it loaded the entire binary into memory. there's is absolutely no rationale for keeping them as separate objects these days.

[opdenkamp]

right okay, guess that's something to look into after all this add-on stuff settled down ;-)

[notspiff]

for reference; this is a q&d way to change it: notspiff/kodi-cmake@1a6241b

[MartijnKaijser]

needs a rebase now.

[FernetMenta]

@opdenkamp can you merge this with your API changes? then we need to adjust the pvr addons only once

[opdenkamp]

we can press the button on both PRs within a few minutes as soon as jenkins is fixed to not fail on android. no need to sync these as it's not bumping the pvr api version, just the gui one, right?

[FernetMenta]

we can press the button on both PRs within a few minutes

yes, that is what I suggested

no need to sync these as it's not bumping the pvr api version, just the gui one, right?

it does not touch pvr API. I thought to remember you saying that pvr API needs a bump if any other APi it uses changed but I may be wrong.

[opdenkamp]

no, just the versions of the add-ons need to be bumped

[opdenkamp]

waiting for jenkins to finish building #6566 too, jenkins build this please
will pull them both if it succeeds