Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] Fix radio channelgroup support. Take over 'radio' group property s... #6755

Merged
merged 1 commit into from Mar 21, 2015

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Mar 18, 2015

Fix radio channelgroup support. Take over 'radio' group property supplied by client.

BTW: IMO, radio channel groups never can have worked without this patch as the "isRadio" flag supplied by clients never was taken into account. Thus, all channel groups were treated as TV groups.

@ksooo
Copy link
Member Author

ksooo commented Mar 19, 2015

@Jalle19 or @opdenkamp mind taking al look?

@ksooo
Copy link
Member Author

ksooo commented Mar 21, 2015

As this is a nobrainer and nobody commented/objected I'm going to merge this after succesfull jenkins build.

@ksooo
Copy link
Member Author

ksooo commented Mar 21, 2015

jenkins build this please

ksooo added a commit that referenced this pull request Mar 21, 2015
[pvr] Fix radio channelgroup support. Take over 'radio' group property s...
@ksooo ksooo merged commit 247c543 into xbmc:master Mar 21, 2015
@ksooo ksooo deleted the fix-radio-channelgroups branch March 21, 2015 21:49
@xhaggi
Copy link
Member

xhaggi commented Mar 22, 2015

looked good :)

@xhaggi
Copy link
Member

xhaggi commented Mar 22, 2015

next time please ping me too

@ksooo
Copy link
Member Author

ksooo commented Mar 22, 2015

@xhaggi sure. sorry, did not know that you're in charge/interest for/of this.

@xhaggi
Copy link
Member

xhaggi commented Mar 22, 2015

np, every PVR change I have an interest in :)

@ksooo
Copy link
Member Author

ksooo commented Mar 22, 2015

@xhaggi hehe. opdenkamp told me some days ago that setting the "PVR" label for a pr is sufficient to automa[t|g]ically get the attention (the review) of all the PVR-devs.

@xhaggi
Copy link
Member

xhaggi commented Mar 22, 2015

sure but sometimes I'm away from github and don't watch the open PR's frequently :)

@opdenkamp
Copy link
Member

or sometimes I have a busy week end and don't have time to check Kodi PRs ;-)

@ksooo
Copy link
Member Author

ksooo commented Mar 23, 2015

np, same here. Had just a little more spare time than usual the last week. Thus, lots of activity on my side. ;-)

@MartijnKaijser MartijnKaijser modified the milestone: I******* 15.0-alpha2 Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v15 Isengard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants