[guilib] hint text not displayed in keyboard dialog #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkortstiege Confirmed working, many thanks. |
mkortstiege
added
Type: Fix
|
jenkins build and merge. |
|
Build errors are unrelated. |
mkortstiege
added a commit
that referenced
this pull request
Mar 20, 2015
[guilib] hint text not displayed in keyboard dialog
BigNoid
pushed a commit
to BigNoid/xbmc
that referenced
this pull request
Mar 21, 2015
[guilib] hint text not displayed in keyboard dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the keyboard dialog is an edit control it should be able to display the hint text provided. First commit adjusts the logic to allow hint text for the keyboard dialog, second one removes now obsolete code.
/cc @BigNoid, @ronie, @HitcherUK. Win32 test build is triggered and should be on the mirrors later today.