[musicdb] enable the library via xml

[mkortstiege]

This enables the the music library nodes to be defined via xml just as we're already doing for the video library.

@Montellese for review please. Btw, I could need some smart playlist help so we can group by first letter. It's not really related to this PR but would come handy to have something like a flat and full blown library to choose from ;)

[mkortstiege]

jenkins build this please.

[SpaceAgeHero]

Is there any documentation on how this could be used?
Can own branches be created from (custom) tags?

[mkortstiege]

@SpaceAgeHero correct, this will allow you to create custom (smartplaylist-based) nodes. See http://kodi.wiki/view/Video_nodes for more information. Please create a forum thread in case you have more questions.

[Montellese]

Looks good AFAICT. Now we only need the unification of library and files view for music and it should be much closer to the video library ;-)

[mkortstiege]

Looks good AFAICT. Now we only need the unification of library and files view for music and it should be much closer to the video library ;-)

Hehe, one at a time. I still wonder myself that i touched the music library ;p

[mkortstiege]

@MilhouseVH mind adding this to your builds so we get some pre-testing before merging?

[MilhouseVH]

Sure no problem, will be in the next build.

[zag2me]

Brilliant, been waiting for this... Tested and everything works as before with music. Tested top 100, singles, mvids ect. Also tested copying the year node and works as it should. Had some trouble with this custom test node, maybe user error though:

[Montellese]

@zag: the <content> tag needs to contain artist (or artists I'm never sure).
The error message is very stupid and we use it in a lot of places ;-) Maybe we should fix that (in a separate PR).

[zag2me]

Sweet! Yeh

<content>artists</content> 

works. Thanks!

[zag2me]

@mkortstiege regarding the first letter filter, I think we would need sub nodes for that to be useful. Not sure if that is possible yet? So it would be: Artists >> A >> Artist list beginning with "A"

[mkortstiege]

@zag2me possible but i'd like to have it dynamic instead of creating a to z nodes ;)

[Montellese]

You can group nodes into directories as we already do it for the video library. But right now having these alphabetically grouped nodes would require an XML per character so not very easy to handle.

That reminds me: Doesn't top 100 contain two sub-nodes? Why aren't they represented with XML files? IMO we should provide an XML file for every "virtual" node.

Another thing that I wanted to try for a while now is use a single root smartplaylist which contains the sub-nodes as virtual folders (which in turn are smartplaylists again). That way we could provide a set of default smartplaylists which reference each other to build the library structure. That way users could edit any of these sub-nodes using the smartplaylist editor and adjust it to their liking. But obviously that's something for another day/week/month. It e.g. doesn't support icons or normal paths like "special://musicplaylists/".

[mkortstiege]

Jep, that's what i meant with i'd like to have it dynamic. Will check Top 100 and Music Vidoes as this one is lacking the sub nodes as well.

[mkortstiege]

Updated. Top 100 and Music videos are now xml based as well.

[Montellese]

Yup looks better now.

[mkortstiege]

Updated. Added HasContent(Music) checks in preparation of Library Mode removal and nuked the extra search node in favor of the regular search function from the (side) menu.

[mkortstiege]

Files node needs to be removed if we decide to get this in before removing the library/files toggle (which i would prefer).

[MilhouseVH]

This needs a small rebase after abc968a

[mkortstiege]

Updated and rebased. I've removed the Files node for now as this required more work that's not directly related to replacing the current nodes with the xml ones.

[zag2me]

Just tested latest build and seems to work as expected.

I still can't get additional sub nodes working though. Tried adding a folder called "T" with an xml inside, but nothing shows up.

EDIT: ahh works now, needs the index.xml

[mkortstiege]

Updated.

[mkortstiege]

jenkins build this please

[mkortstiege]

If no one objects I will merge this one the other day.

[zag2me]

+1 from me.

Working well and a pretty huge feature for us with larger music collections.

I'll get started on the documentation for this soon on the Wiki.

[mkortstiege]

Rebased. jenkins build and merge.