[tagloader] make TagLoaderFactory load by item (fixes #15879) #6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkortstiege
added
Type: Fix
|
looks good. |
|
jenkins build this please. |
|
@Montellese mind having a quick look as well? |
|
Built locally on Ubuntu. Works for me, http source music scan is behaving as expected. |
| @@ -20,6 +20,7 @@ | |||
| */ | |||
|
|
|||
| #include "ImusicInfoTagLoader.h" | |||
| #include "FileItem.h" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good apart from the comment. |
mkortstiege
force-pushed
the
tag_loader_by_item
branch
from
317a836
to
3c1145b
Compare
|
@Montellese thanks. Made it using a forward declaration for |
xhaggi
added a commit
that referenced
this pull request
Mar 26, 2015
[tagloader] make TagLoaderFactory load by item (fixes #15879)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
TagLoaderFactoryto load by item rather than path in order to ensure previously set item properties are considered. Furthermore it makes no sense to create a new item based on the already known item path. Closes http://trac.kodi.tv/ticket/15879.