fix htmltow test case #6817
Merged
fix htmltow test case #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EXPECT_TRUE(memcmp(firstBuf.c_str(), buf, firstBuf.length()) == 0); | ||
| EXPECT_TRUE(file.Read(buf, secondBuf.length())); | ||
| EXPECT_EQ(0, memcmp(firstBuf.c_str(), buf, firstBuf.length())); | ||
| EXPECT_EQ(secondBuf.length(), file.Read(buf, secondBuf.length())); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Fine work in general :) |
|
cleaned it up a bit more with the parenthesis and fixed the !memcmp you spotted |
|
sry one thing left - prefix the commit message with [tests] please to give it a proper context. After then feel free to merge |
…some cleanup as well Fix failing test case text encoding in source file made the test fail on win32
Paxxi
added a commit
that referenced
this pull request
Mar 26, 2015
[tests] fix htmltow test case and some cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this silences a bunch of forced conversion to bool performance warnings in VS and also fixes the htmltow test case that failed because of source file encoding issues.
@Memphiz what do you think?