[confluence] add pcm, pcm_s16le and pcm_s24le audio flags

[un1versal]

This solves no audio flag being present when we playing wav files that contain pcm stream now that most is handled via ffmpeg and not whatever we use to have in kodi, as I remember those use to be ok back then.

• A example of such is where we use the _audioencoder.wav_ addon to rip a cd to wav which results in _pcm_s16le_ stream.
• Playing a cd directly the stream is _pcm_ audio and also has no flag so adding it here seems the logical thing to do.
• When I tested and external ripper to wav the stream was _pcm_s24le_ and also no flag in confluence. this fixes that also.

Without PR these 3 look like screenshot below.

This is playing a externally ripped file to wav with pcm_s24le

This is after playing a CD

There maybe others that have no flags in confluence on playback but for time being these are now handled via this PR and display expected flag.

@fritsch @ronie

[un1versal]

Adding a reference to List of formats as id by ffmpeg in case someone can spot more that are potentially common enough to justify making flags for them.

[ronie]

looks good to me. or does someone prefer a 'wav' flag instead of 'pcm' for this?

[jjd-uk]

"WAV" is a container and we already have an icon for that https://github.com/xbmc/xbmc/blob/master/addons/skin.confluence/media/flagging/audio/wav.png

So shouldn't we display both the "WAV" and "PCM" flag

[ronie]

i know. so which one do you prefer?

[jjd-uk]

Edited previous post.

Is it possible to show both, as it's also valid to have "DTS" in a "WAV"?

[fritsch]

You really want to see WAV next to DTS? That's not really of enduser
interest? The devs sees that in the log.

2015-03-26 17:39 GMT+01:00 jjd-uk notifications@github.com:

Edited previous post.

Is it possible to show both, as it'a also valid to have "DTS" in a "WAV"?

Reply to this email directly or view it on GitHub
#6823 (comment).

               Key-ID:     0x1A995A9B
               keyserver: pgp.mit.edu

Fingerprint: 4606 DA19 EC2E 9A0B 0157 C81B DA07 CF63 1A99 5A9B

[jjd-uk]

Not that bothered just raising the point. So sticking with the contents in this case "PCM" is fine by me.

[un1versal]

Well, I decided to go with pcm cause indeed it is pcm as per codec identification of both ffmpeg and mediainfo.

@ronie, given we dont display containers I think the wav flag can be deleted as it wont ever show up now ffmpeg is handling this, same would apply to other containers I would think as it will be the stream/codec that shows up and thats what we should show the user.
I guess this issue will occur elsewhere when the container isn't displayed and the audio flag name doesn't match the codec/stream inside, no?

[Jalle19]

WAV might be more user-friendly, normal people don't know what PCM is.