New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[music videos] adding "All albums" option #6871
Conversation
Adds the missing "All albums" option when browsing Music Videos by Artist, which was requested in http://forum.kodi.tv/showthread.php?tid=185443
[music videos] adding "All albums" option
One of these commits is too many |
To clarify what I think @universal meant is that you should squish your commits into one. |
I might need some guidance; I haven't used Git before, so unfortunately I don't know how to do that (without possibly making an even bigger mess). Sorry for the inconvenience. |
@sialivi There's a few ways to do this. One way is. 1 ) open a terminal in your git master branch and issue these commands:
shortly after, your text editor will open up with the two commits ontop and some comments below:
pay attention to this part on that text file _# If you remove a line here THAT COMMIT WILL BE LOST._
Git will do some work and that removes the unwanted commit. Then push chnages which updates this PR automatically by issuing: :
_note:_
that should do it, there's several ways how to do this I suggest you brush up by doing some reading and practising. |
@UniversaI Sorry for the late reply, I'm hospitalized for an extended period of time. Thanks for the detailed steps, unfortunately I'm not set up to perform them from my tablet. I see there's already a rc1 ticket, so chances are that I won't be discharged from hospital in time to fix this. Maybe it's possible for some other kind soul to do it. |
Ill see about cherry picking these commits and pushing them on your behalf. |
@UniversaI That would be most appreciated, if it's not too late now that RC2 is out. |
Adds the missing "All albums" option when browsing Music Videos by Artist, which was requested in this thread.