Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: add a fallback site for internet detection #6885

Merged
merged 1 commit into from May 23, 2015

Conversation

koying
Copy link
Contributor

@koying koying commented Apr 6, 2015

Somehow, google might be blocked ("Great Wall", firewall, proxy).
Little chance anyone would care to block w3c ;)

/cc @Montellese

@mkortstiege
Copy link
Member

Seem legit but i wonder if we should use an internal (kodi) site first.

@koying
Copy link
Contributor Author

koying commented Apr 6, 2015

Any non-contentious, 99.9% up, site really.
Kodi, being categorized as "entertainment" might be blocked in, e.g., office environments

@mkortstiege
Copy link
Member

Oh, right. w3c sounds like a good choice then.

@samnazarko
Copy link
Contributor

I think you should use time.windows.com. It's what MS Windows uses around the world, so there is, by extension, an element of reliability.

Another problem with using Google, or sites that have geo-location based redirect, is Kodi does not handle the redirect properly. Example: try http://google.com and it will report 'not connected' in the UK, because it is not handling the direct to http://google.co.uk properly. If you use http://google.co.uk explicitly, it's fine.

@koying
Copy link
Contributor Author

koying commented May 15, 2015

Well, time.window.com is their ntp server, isn't it? We do a simple http get on 80 for this.
It happens that there is a landing http page, there, but I'm not sure we can assume it's anywhere reliable...

@samnazarko
Copy link
Contributor

Wrong URL, my bad,

http://www.msftncsi.com/ncsi.txt is what OSMC uses (and Windows clients too)

@koying
Copy link
Contributor Author

koying commented May 19, 2015

Makes sense. This is the site MS tries to reach to check Windows internet connectivity.

@mkortstiege
Copy link
Member

@koying mind updating so we can merge this one?

Somehow, google might be blocked ("Great Wall", firewall, proxy).
Little chance anyone would care to block w3c ;)
@koying
Copy link
Contributor Author

koying commented May 23, 2015

Done. I've made the MS one primary, and kept W3C as secondary.

@MartijnKaijser MartijnKaijser added this to the Isengard 15.0-beta2 milestone May 23, 2015
@mkortstiege
Copy link
Member

Thanks. jenkins build this plase.

@MartijnKaijser
Copy link
Member

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 8c6fed2 into xbmc:master May 23, 2015
@koying koying deleted the addfallbackinet branch May 23, 2015 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants