Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infomanager] add ListItem.IsCollection #6896

Closed
wants to merge 1 commit into from

Conversation

mkortstiege
Copy link
Member

Adds boolean info label ListItem.IsCollection.

@un1versal
Copy link
Contributor

@mkortstiege thanks for adding this. @ronie @da-anda this comment only here to show what possible.

Lacking experience in skinning limits me, based on this PR above, I hacked around to tried to implement this into confluence.

See un1versal@0a02a47

Literally just copied the 3D flag implementation. I think.

Before
screenshot034

After
screenshot035

There are a few problems with this:
  1. When you focus on the collection in list view, the flag disappears _Battlestar Galactica Collection_ example

  2. The flag is only visible in _Media Info View 2_ I probably missed something somewhere if not the 3D flag will have same issues.

  3. Position is copied from 3D flag implementation so it will overlap with 3D in some conditions.

For these 3 reason I dint PR this half hack as clearly my attempt is flawed but shows what is possible with the correct skinning skills. Would be nice to get it in and take listview a little closer when moviesets are listed.

@da-anda
Copy link
Member

da-anda commented Apr 7, 2015

I don't think we need the collection icon along with the stream details because a collection usually doesn't have any stream details and would be a lonely icon just like in your BattleStar screenshot. Adding the icon to the list is nice though.

@un1versal
Copy link
Contributor

@da-anda, Yes! See Discussion on my attempt above. as its not ontopic and it is github after all. 👍

@phil65
Copy link
Contributor

phil65 commented Apr 7, 2015

added by removing code ;)
#6900

@mkortstiege
Copy link
Member Author

Included in #6900. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants