[video] no need to re-fetch (and stack) directory in case we already kno... #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,7 @@ void CGUIWindowVideoBase::OnInfo(CFileItem* pItem, ADDON::ScraperPtr& scraper) | |||
| // so take a copy of the item now | |||
| CFileItem item(*pItem); | |||
| bool fromDB = false; | |||
| if (item.IsVideoDb() && item.HasVideoInfoTag()) | |||
| if (item.IsVideoDb() || (item.HasVideoInfoTag() && item.GetVideoInfoTag()->m_iDbId != -1)) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
xhaggi
added
the
Type: Improvement
|
Updated. Double checking now. |
|
Looks good. I agree with @xhaggi's comments. |
mkortstiege
added a commit
that referenced
this pull request
Apr 18, 2015
[video] no need to re-fetch (and stack) directory in case we already kno...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a useless extra directory fetch and stacking when you hit
infoon a folder that is already added and known.@Montellese, @xhaggi for review please.