Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] add pvr.vbox (new PVR addon) #6985

Merged
merged 1 commit into from Apr 23, 2015
Merged

Conversation

Jalle19
Copy link
Member

@Jalle19 Jalle19 commented Apr 20, 2015

This is a new addon I've developed for use with VBox TV Gateway devices (see http://www.vboxcomm.com/products/xti-family.html).

@opdenkamp have I missed something or is this all that is required for inclusion?

@Jalle19 Jalle19 added this to the Isengard 15.0-beta1 milestone Apr 20, 2015
@Jalle19
Copy link
Member Author

Jalle19 commented Apr 20, 2015

jenkins build addons please

@hudokkow
Copy link
Member

That's all it's needed.
No need for the complete commit SHA. First 7 digits is enough.

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 20, 2015

@hudokkow copying the whole hash was easier. Does it hurt to have the full hash there or should I change it?

@hudokkow
Copy link
Member

I don't think it hurts at all. Atleast jenkins builds fine. I guess it's a matter of consistency.
Nice add-on, btw.

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 20, 2015

@hudokkow thanks

I'll merge this in the upcoming days unless anyone has any objections. If someone wants to review the code, be my guest!

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 21, 2015

I have some last minute changes pending so I'll update this PR at least once still before merging.

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 22, 2015

jenkins build addons please

Jalle19 added a commit that referenced this pull request Apr 23, 2015
[pvr] add pvr.vbox (new PVR addon)
@Jalle19 Jalle19 merged commit e369203 into xbmc:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants