Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 7 seconds as a seek option in the GUI without changing the defaults. #7007

Closed
wants to merge 1 commit into from
Closed

Conversation

NedScott
Copy link
Contributor

This only makes it possible to select 7 seconds in the GUI. It is not selected by default. I'm hoping this is a fair compromise, since it is still easier to select in the GUI than making a keymap or advancedsettings.xml file.

7 seconds as a jump back has long since proven itself and is not an arbitrary value. People have tried to use other values for smallstepback/quick jump backs, and have compared our -7 seconds to what other video players use (5, 10, 15, etc), and what I've seen shows specific support for that amount of time. A lot of people are going to want an easy way to select that again in the GUI, especially after being used to 7 seconds for over 5 years. (5 years at least, I haven't found the exact date.)

This only makes it possible to select 7 seconds in the GUI. It is not selected by default. I'm hoping this is a fair compromise, since it is still easier to select in the GUI than making a keymap or advancedsettings.xml file.

7 seconds as a jump back has long since proven itself and is not an arbitrary value. People have tried to use other values for smallstepback/quick jump backs, and have compared our -7 seconds to other video players, and what I've seen shows specific support for that amount of time. A lot of people are going to want an easy way to select that again, especially after being used to 7 seconds for over 5 years (at least, I haven't found the exact date).
@NedScott
Copy link
Contributor Author

@xhaggi @da-anda @jjd-uk @FernetMenta

I leave this decision to you.

@jjd-uk
Copy link
Member

jjd-uk commented Apr 22, 2015

The problem with this is that the values provided here mean both a minus and plus value is shown, it is not possible to only specify a minus value. FernetMenta has given valid reasons why you never want a +7s value to be selected, so as a consequence we must also lose -7s from the additive seeking.

A better compromise maybe to add:

<SOMEKEY>Seek(-7)</SOMEKEY>

to the default keymaps.

@NedScott
Copy link
Contributor Author

No, FernetMenta explained why +7 takes longer for some people.

Seeking forward less than 10 seconds is a problem that only affects some users, with some hardware, with some videos. It also had nothing to do with the delays that started this whole discussion about seeksteps taking longer, which is a different issue.

Removing -7/+7 from the defaults (but still allowing it to be selected without editing an xml file) is more than enough to help the rare cases were this might be an issue, and without making the program a lot less user friendly for the majority of users.

@NedScott
Copy link
Contributor Author

Alternatively, we could replace smallstepback in all our default keymaps with seek(-7), or undo xhaggi@bdd23e8

@jjd-uk
Copy link
Member

jjd-uk commented Apr 22, 2015

That's exactly what I meant, replace smallstepback with seek(-7) in the keymaps, as I think that will probably the most acceptable way to all.

@NedScott
Copy link
Contributor Author

I like that idea the best now. Thanks jjd-uk! I'll close this and open a PR with updated keymaps.

@NedScott NedScott closed this Apr 23, 2015
@NedScott NedScott deleted the 7seconds branch April 23, 2015 00:11
@NedScott
Copy link
Contributor Author

#7008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants