Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add romanian keyboard layout #7009

Merged
merged 1 commit into from
May 9, 2015
Merged

Add romanian keyboard layout #7009

merged 1 commit into from
May 9, 2015

Conversation

Danny3
Copy link
Contributor

@Danny3 Danny3 commented Apr 23, 2015

Hi guys

I added the romanian keyboard layout

For this to work properly this ticket must be fixed:
http://trac.kodi.tv/ticket/15847
It takes less than 2 minutes (see my comment there)
On my computer is fixed so this works as it should
I didn't include the fix in this pull request since I don't want to overstep and I'm not sure if github can show the difference between the two fonts.

Also I wanted to update the romanian langinfo.xml, but i couldn't find it
Before it was in the root directory in language/romanian folder
Can you tell me where is it now?

Thanks

Add romanian keyboard layout as per standard SR 13392:2004
http://en.wikipedia.org/wiki/Romanian_keyboard_layout
This is the "primary" layout with one exception
Letter "â" is on the next row sice the virtual keyboard can only show a
max of 12 characters
Google and Microsoft did the same with their virtual keyboards
@un1versal
Copy link
Contributor

@Danny3 , for fonts see #7010 and the trac comment

Also I wanted to update the romanian langinfo.xml, but i couldn't find it
Before it was in the root directory in language/romanian folder
Can you tell me where is it now?

see https://github.com/xbmc/repo-resources/tree/isengard/resource.language.bg_bg/resources

@Danny3
Copy link
Contributor Author

Danny3 commented May 4, 2015

Guys could you tell me please why is this being ignored?
Is there a problem with it?

@un1versal
Copy link
Contributor

@MartijnKaijser for review

@Danny3 be patient

I wanted to update the romanian langinfo.xml,

Its at https://github.com/xbmc/repo-resources/tree/isengard/resource.language.bg_bg/resources
are you going to edit it and add it to this PR or?

@Danny3
Copy link
Contributor Author

Danny3 commented May 5, 2015

@UniversaI
I'm sorry I'm patient and don't want to upset anyone
The problem is that this is my second PR for this thing( first one was not accepted for being too late) and in the future I'm not sure if I will still have the time to keep an eye on this

Btw, thanks for the updated fonts, the bug is solved

Now about langinfo.xml
Yes, I want to edit it to fix some things there
I don't know what you mean to add it to this PR
Do you mean like a reference like you did with the fonts PR?
I have 2 problems

  1. I have installed Kodi 15 beta 1 on my win7 computer and I can't find where langinfo.xml is so I can properly test the changes
    I expected it to be in addons folder similar to 'resource.language.en_gb'
    Windows and text editors search by filename or content fails to find it
  2. I remember when I first made that file there was a field to specify the charset for the subtitle
    At that time I added only the iso code for Central Europe, this was the recommended one to display subtitles correctly
    Now I want to also add utf-8 as a valid option for subtitles encoding if specifying 2 encodings is possible
    The problem here is that I can no longer find that field anywhere
    Has been removed over time or my memory is failing?

@Montellese
Copy link
Member

@Danny3: The langinfo.xml file is located in %userdata%/addons/resource.language.bg_bg/resource/ but stuff like subtitles charset has been moved to addon.xml so you have to modify the addon.xml of the addon (see https://github.com/xbmc/repo-resources/blob/isengard/resource.language.bg_bg/addon.xml) which is no longer part of this git repository.

@Danny3
Copy link
Contributor Author

Danny3 commented May 5, 2015

@Montellese
Big thank you
I found everything there
You solved another 2 problems that I was having

  1. As a translator before Kodi 15 I would download po files from transifex and overwrite the ones Kodi had in installation folder so I would not have to wait for new releases to see how the strings look and where they appear.
    With Kodi 15 I could only find confluence's translation file
  2. Weird setting overriding in one of my reported bugs

http://trac.kodi.tv/ticket/15823
Now it's clear

If we'll ever meet I owe you some beers :)

I will make the changes and when I'm done I will make a PR there

@MartijnKaijser MartijnKaijser added this to the Isengard 15.0-beta2 milestone May 9, 2015
MartijnKaijser added a commit that referenced this pull request May 9, 2015
Add romanian keyboard layout
@MartijnKaijser MartijnKaijser merged commit 1d75f8e into xbmc:master May 9, 2015
@Danny3
Copy link
Contributor Author

Danny3 commented May 10, 2015

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants