Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OS X i386 Xcode builds on x86_64 build machines #7078

Closed
wants to merge 4 commits into from

Conversation

HofiOne
Copy link
Contributor

@HofiOne HofiOne commented May 7, 2015

1.)
Without assigning App-OSX.xcconfig to Kodi.app target building i386
target will not fix dependent libraries when bundling the Kodi.app with
copyframeworks-osx.command

copyframeworks-osx.command uses XBMC_DEPENDS that composed like
$(XBMC_DEPENDS_ROOT)/$(SDK_NAME)_$(CURRENT_ARCH)-target

CURRENT_ARCH not set correctly, without assigning App-OSX.xcconfig the
ONLY_ACTIVE_ARCH is not set and the builder machine architecture will
be used instead of the targeted architecture.

2.)
Also found that XCode 6.1.1 on OSX 10.10.4 does not build Kodi, suggest to recommend XCode 6.3.1 on 10.10

Without assigning App-OSX.xcconfig to Kodi.app target building i386
target will not fix dependent libraries when bundling the Kodi.app with
copyframeworks-osx.command

copyframeworks-osx.command uses XBMC_DEPENDS that composed like
$(XBMC_DEPENDS_ROOT)/$(SDK_NAME)_$(CURRENT_ARCH)-target

CURRENT_ARCH not set correctly, without assigning App-OSX.xcconfig the
ONLY_ACTIVE_ARCH is not set and the builder machine architecture will
be used instead of the targeted architecture.
@HofiOne
Copy link
Contributor Author

HofiOne commented May 7, 2015

Sorry the first line

+On Mavericks (OSX 10.9.x) we recommend using Xcode 6.3.1.

was accidental, I've tested on 10.10 only and only that change suggested.

if you did it on a stock os and worked that is a much better test.
unfortunately using XCode 6.1.1 is problematic on my boxes (both at home and work) I'd be curious what could cause that problem

apart from that, i'v made a 2nd big mistake and pushed the 2 changes together when they are not related at all. the change in the xcode project file is necessary to build correct bundled app from the IDE.

@Memphiz
Copy link
Member

Memphiz commented May 7, 2015

Yes just change your branch so that it only contains the 2 lines in xcode and commit it as extra commit. After that do git rebase HEAD~2 -i and "r"ename the first and "f"ixup the scond commit. After that name the first commit correctly like you did already. After that force push to your repo and this PR gets updated automagically ...

Without assigning App-OSX.xcconfig to Kodi.app target building i386
target will not fix dependent libraries when bundling the Kodi.app with
copyframeworks-osx.command

copyframeworks-osx.command uses XBMC_DEPENDS that composed like
$(XBMC_DEPENDS_ROOT)/$(SDK_NAME)_$(CURRENT_ARCH)-target

CURRENT_ARCH not set correctly, without assigning App-OSX.xcconfig the
ONLY_ACTIVE_ARCH is not set and the builder machine architecture will
be used instead of the targeted architecture.
…/xbmc into Fix-Enhance-XCode-Builds

* 'Fix-Enhance-XCode-Builds' of https://github.com/HofiOne/xbmc:
  Fixed OS X i386 Xcode builds on x86_64 build machines
@HofiOne HofiOne closed this May 7, 2015
@HofiOne HofiOne deleted the Fix-Enhance-XCode-Builds branch May 7, 2015 22:56
@HofiOne
Copy link
Contributor Author

HofiOne commented May 7, 2015

I've successfully f@cked up the revert so creating a new pull request instead, sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants