renderer: Use a structure for information passed from renderer to codec #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is required by a forthcoming MMAL bug fix, so I'd like this to be considered for Isenguard. jenkins build this please |
I need an additional opaque pointer to be passed from renderer to codec (to allow a pool owned by renderer to be used by decoder). It was decided rather than adding an extra function/parameter that entending the information to use a structure would be more maintainable.
popcornmix
force-pushed
the
renderer_decoder
branch
from
53145e7
to
d535343
Compare
|
Updated. |
|
Windows failure doesn't look to be related: |
|
looks ok, would be great if this could be runtime tested on some platforms. |
|
Tested a linux build with and without hardware acceleration and videos played fine. |
|
ok, merge at you will |
popcornmix
added a commit
that referenced
this pull request
May 9, 2015
renderer: Use a structure for information passed from renderer to codec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need an additional opaque pointer to be passed from renderer to codec
(to allow a pool owned by renderer to be used by decoder).
It was decided rather than adding an extra function/parameter that
entending the information to use a structure would be more maintainable.