Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPnP: fix playcount and watched state of tvshows and seasons #7191

Merged
merged 2 commits into from May 29, 2015
Merged

UPnP: fix playcount and watched state of tvshows and seasons #7191

merged 2 commits into from May 29, 2015

Conversation

Montellese
Copy link
Member

These two commits fix two issues with the playcount and watched state of tvshows and seasons from a UPnP server:

  • the watched overlay isn't displayed properly if the total playcount of all episodes is bigger than the total number of episodes
  • tvshows with a single watched episode are considered watched and are therefore hidden when using "Hide watched"

@Montellese Montellese added the Type: Fix non-breaking change which fixes an issue label May 25, 2015
@mkortstiege
Copy link
Member

Is SetOverlayImage() still needed after having m_playCount for shows and seasons? Other than that it looks good to me.

@Montellese
Copy link
Member Author

Since this is set by CVideoDatabase for video library items (which doesn't make much sense IMO) I'm pretty sure that it is still needed.
jenkins build this please

@Montellese Montellese added this to the Isengard 15.0-beta2 milestone May 29, 2015
Montellese added a commit that referenced this pull request May 29, 2015
@Montellese
Merge pull request #7191 from Montellese/upnp_playcount_fixes
c34fc22 
UPnP: fix playcount and watched state of tvshows and seasons
@Montellese Montellese merged commit c34fc22 into xbmc:master May 29, 2015
@Montellese Montellese deleted the upnp_playcount_fixes branch May 29, 2015 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Isengard 15.0-beta2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Montellese @mkortstiege