New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed: Curl's overflow buffer handling #7198
Conversation
ea17dab
to
445dcd5
Compare
jenkins build this please |
d823341
to
5004105
Compare
2ed2369
to
277d3dd
Compare
Not my department really. Maybe @Paxxi could have a look at this as well? |
@arnova Both calls to memcpy should be replaced with memmove afaik. Memcpy where dst and src overlap is undefined behaviour, will need to go through it more thoroughly for rest of the review. |
@Paxxi: Yeah but memmove is slower since it uses an extra buffer and doesn't memcpy start at the bottom? |
If it overlaps -> no memcpy. |
jenkins build this please |
ignore build fail |
@Paxxi : You're fine with this? |
@arnova yup looks fine |
changed: Curl's overflow buffer handling
@mkortstiege : Please review.