AESinkPULSE: Make buffer settings more failsafe #7247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
Win32 not related. |
fritsch
added a commit
that referenced
this pull request
Jul 13, 2015
AESinkPULSE: Make buffer settings more failsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, e.g. no hwdevice and not default device we would have created devices that have 2 seconds buffer and 500 ms audio data, which would be more data than available in audio engine. Therefore limit the chunks to 100 ms and buffer to 400 ms in that case.
Normal case, when we are a hwdevice, we still aim for 200 / 50.