[epg] Remove call a bit #7253
Merged
[epg] Remove call a bit #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Looks sane to me. |
|
+1 jenkins build this please |
| @@ -859,6 +860,6 @@ bool CEpg::IsValid(void) const | |||
| { | |||
| CSingleLock lock(m_critSection); | |||
| if (ScraperName() == "client") | |||
| return Channel().get() != NULL; | |||
| return m_pvrChannel.get() != NULL; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
AlwinEsch
force-pushed
the
pvr-code-cleanup
branch
from
3ab7e1a
to
088d522
Compare
|
Is updated, @opdenkamp has removed the change on the point with the bad lock. |
|
great thanks |
|
jenkins build this please |
|
OK to merge? Then I add the next from #6877 to a new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove the amount of functions calls on egp load a bit.
In machine code are for around on 1 epg entry 2-4 calls removed, for 10000 epg entries it is a lot for me and can reduce the time a bit (Not much, but better as nothing)
This change is taken from #6877 to have only the there described fault on end.