Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: Properly exit screensaver on shutdown (fixes #16028) #7254

Merged
merged 1 commit into from Jun 14, 2015

Conversation

arnova
Copy link
Member

@arnova arnova commented Jun 10, 2015

Ideally we should abort any Python (addon) script before we start shutting down, but some skins (why?) rely on some addons, so (for now?) let's at least properly shutdown the screensaver. This also partially fixes the crash in ticket #16028.

@MartijnKaijser
Copy link
Member

i guess it makes sense to wake from screensaver before shutting down

@MartijnKaijser
Copy link
Member

@jimfcarroll any suggestions about the python add-ons?

@arnova
Copy link
Member Author

arnova commented Jun 11, 2015

Note that this does NOT fully fix ticket #16028, it just makes the race causing the crash less likely.

@arnova arnova added Type: Fix non-breaking change which fixes an issue v15 Isengard labels Jun 11, 2015
@jimfcarroll
Copy link
Member

The python script shutdown doesn't take into account order or dependency. I'm not sure how to resolve this. Perhaps we could add a reference counting mechanism.

@arnova
Copy link
Member Author

arnova commented Jun 12, 2015

@jimfcarroll : You mean that instead of shutting down all scripts after the skin is unloaded, just unload the ones of which we know they are actually not used anymore? Another idea could be simply flagging them as such simply with a boolean in the addon object we can set/check, and unload everything before the skin unload that doesn't have that flag set? Perhaps we should continue this discussion in http://trac.kodi.tv/ticket/16028 ?

I think we should merge this PR anyway as that's a separate issue.

@MartijnKaijser MartijnKaijser added this to the Isengard 15.0-beta2 milestone Jun 13, 2015
@MartijnKaijser
Copy link
Member

just to be sure
jenkins build this please

MartijnKaijser added a commit that referenced this pull request Jun 14, 2015
changed: Properly exit screensaver on shutdown (fixes #16028)
@MartijnKaijser MartijnKaijser merged commit e153e06 into xbmc:master Jun 14, 2015
@arnova arnova deleted the screensaver_crash branch February 16, 2016 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v15 Isengard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants