[subs] Some improvements and a fix for subs in archives #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rearrange the list of subtitle extension - Add break/continue to loops
|
Diff without cosmetics: https://github.com/xbmc/xbmc/pull/7285/files?w=1 |
|
Not sure about dropping OT: I really question why we're supporting archive in archive subs ;) This is such a silly idea .. |
|
As far as I’m concerned, we could remove support for archived items completely. |
That is the mentioned fix. But I forgot to test rars in zips and vice versa.... |
|
jenkins build this please @MartijnKaijser 15.0? |
|
I see no reason to test this weird scenario. jenkins build this please. |
|
if you guys think it's safe enough. |
ace20022
added a commit
that referenced
this pull request
Jun 15, 2015
[subs] Some improvements and a fix for subs in archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.