Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluence] add missing video codec flags #7289

Merged
merged 1 commit into from
Jun 21, 2015

Conversation

un1versal
Copy link
Contributor

@da-anda @ronie this is isengard safe.

Klojum at IRC mentioned (yesterday) that hev1 didnt have a codec flag, someone else from my generation had mentioned also that windows media video files also dont have codec flags,
This should cure both and has been tested.

@da-anda
Copy link
Member

da-anda commented Jun 16, 2015

HEV1? I only know h265 as HEVC and a quick google search also didn't give much info about HEV1. So is HEV1 correct?

@phil65
Copy link
Contributor

phil65 commented Jun 16, 2015

yes, seems to exist, but I dont think we have to show that term to the user. Just using the default H265 image would be nicer imo.

@un1versal
Copy link
Contributor Author

Mentions hev1 https://ffmpeg.org/pipermail/ffmpeg-cvslog/2014-March/074993.html some explanations http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ea3309eba715e83027e8ece4a226e39a4bf2a6ce

edit iso standards mention hev1 and hvc1 also both are different parameters/restrictions

I see no issue with making the distinction since some distinction clearly exists however technical has no harm showing imo, but I dont have a preference.

@da-anda
Copy link
Member

da-anda commented Jun 16, 2015

I leave it up to the codec guys if they think we have to differ between HEVC and HEV1. To me it doesn't add any value and I also believe the media flags should not go into too much details, so also using the HEVC icon whould be fine for me.

@un1versal
Copy link
Contributor Author

Yes I agree, its HEVC, HEV1, HVC1 so I think the default copy is best.

@MartijnKaijser
Copy link
Member

ok for me. objections?

@da-anda
Copy link
Member

da-anda commented Jun 18, 2015

nope

@MartijnKaijser MartijnKaijser added this to the Isengard 15.0-rc1 milestone Jun 18, 2015
MartijnKaijser added a commit that referenced this pull request Jun 21, 2015
[confluence] add missing video codec flags
@MartijnKaijser MartijnKaijser merged commit 82f7f07 into xbmc:master Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants