Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initalize vars claimed by valgrind / write classname instead 'PVR' in… #7323

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Initalize vars claimed by valgrind / write classname instead 'PVR' in… #7323

merged 1 commit into from
Jul 11, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 21, 2015

… PVRChannelGroups:LOGDEBUG to make debugging easier

I wasn't able to read my valgrind log because of the mass of messages (as I remember GUIShader was the worst one), I have eliminated all the others and now it looks clean.

… PVRChannelGroups:LOGDEBUG to make debugging easier
@hudokkow
Copy link
Member

Thanks, looks good.
jenkins build this please

@mkortstiege
Copy link
Member

Not sure about the platinum change. Is this our code or should it be send upstream? @Montellese mind having a look?

@Paxxi
Copy link
Member

Paxxi commented Jul 11, 2015

@mkortstiege Upstreaming can be looked at but no reason to block this pr.

Paxxi added a commit that referenced this pull request Jul 11, 2015
Initalize vars claimed by valgrind / write classname instead 'PVR' in…
@Paxxi Paxxi merged commit 5aaaf8c into xbmc:master Jul 11, 2015
@MartijnKaijser MartijnKaijser modified the milestone: J**** 16.0-alpha1 Jul 11, 2015
@MilhouseVH
Copy link
Contributor

Confirming notification problem reported by @Uukrull.

Easy way to reproduce (change port 8080 to whatever your webserver is using):

curl --data-binary '{"jsonrpc": "2.0", "params": {"message": "This is the message", "image": "error", "displaytime": 5000, "title": "This Is the title"}, "method": "GUI.ShowNotification", "id": "libNotification"}' -H 'content-type:application/json;' 'http://localhost:8080/jsonrpc'

should produce a notification with title "This Is the title" and message "This is the message" text, and Error icon, but currently there is no text.

phil65 added a commit to phil65/xbmc that referenced this pull request Jul 13, 2015
braz96 pushed a commit to braz96/xbmc that referenced this pull request Jul 14, 2015
@ghost ghost deleted the xbmc_cosmetic branch March 29, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants