Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: always check the result of mysql_store_result() against NULL (fixes #16071) #7353

Merged
merged 1 commit into from Jul 5, 2015

Conversation

Projects
None yet
5 participants
@Montellese
Copy link
Member

commented Jun 28, 2015

This is an attempt to fix http://trac.kodi.tv/ticket/16071. As described in detail in the ticket any call to mysql_store_result() can return NULL so we have to check against it before further using the result.

Unfortunately I'm unable to really test this and the situation reported in the ticket is not really common either.

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2015

jenkins build this please

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2015

Only some binary addons that failed to build. @Memphiz: I thought failing binary addons wouldn't mark a build as broken?

@Memphiz

This comment has been minimized.

Copy link
Member

commented Jul 1, 2015

@Montellese mhhh not sure - it was setup that unstable builds are marked as failed on github. Changed it to be marked as success instead - though i hope people will have a look on jenkins then for not breaking addons by accident. Also this changes behavior for the merge trigger (before it wouldn't merge if build is unstable due to addons - now it will...)

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2015

@Memphiz: Ah maybe I just misunderstood. I'm fine with either way (as long as I know how it works).

@mkortstiege

This comment has been minimized.

Copy link
Member

commented Jul 2, 2015

@MilhouseVH any chance you can give it a try? jenkins build this please.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2015

I've included this PR since build #0628 (28 Jun) and no reported problems so far...

@mkortstiege

This comment has been minimized.

Copy link
Member

commented Jul 5, 2015

jenkins build this please.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jul 5, 2015

jenkins build this please

mkortstiege added a commit that referenced this pull request Jul 5, 2015

Merge pull request #7353 from Montellese/fix_mysql_num_rows
mysql: always check the result of mysql_store_result() against NULL (fixes #16071)

@mkortstiege mkortstiege merged commit 3d84a0f into xbmc:master Jul 5, 2015

1 check passed

default Merged build finished.
Details

@Montellese Montellese deleted the Montellese:fix_mysql_num_rows branch Jul 5, 2015

@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.