mysql: always check the result of mysql_store_result() against NULL (fixes #16071) #7353
Conversation
|
jenkins build this please |
|
Only some binary addons that failed to build. @Memphiz: I thought failing binary addons wouldn't mark a build as broken? |
|
@Montellese mhhh not sure - it was setup that unstable builds are marked as failed on github. Changed it to be marked as success instead - though i hope people will have a look on jenkins then for not breaking addons by accident. Also this changes behavior for the merge trigger (before it wouldn't merge if build is unstable due to addons - now it will...) |
|
@Memphiz: Ah maybe I just misunderstood. I'm fine with either way (as long as I know how it works). |
|
@MilhouseVH any chance you can give it a try? jenkins build this please. |
|
I've included this PR since build #0628 (28 Jun) and no reported problems so far... |
|
jenkins build this please. |
|
jenkins build this please |
mysql: always check the result of mysql_store_result() against NULL (fixes #16071)
This is an attempt to fix http://trac.kodi.tv/ticket/16071. As described in detail in the ticket any call to
mysql_store_result()can returnNULLso we have to check against it before further using the result.Unfortunately I'm unable to really test this and the situation reported in the ticket is not really common either.