Add a method to retrieve video tags

[phate89]

Right now you can retrieve all tags from a media type using a "trick" (Files.GetDirectory to videodb://movies/tags/ for example) but imho a specific method is better.
Exactly like "GetGenres" is more obvious to try to use a "GetTags" instead of using files.getdirectory

[Montellese]

Looks ok apart from the minors.

[phate89]

It should be fixed now. I don't know why I thought tags had thumbnails..

[Tolriq]

Since this is related to the GetGenres too, is it possible to complete the PR to also return the TAG ids when querying for the movies ?

Because as with genre this will lead to a list of movie with tags as strings and a getTags that return the tags and ids but no way to link them in offline cache (for remotes for example) except by recreating fake ids or tons of string searches, leading to this function a little less useful.

(Of course same thing for genre would be perfect).

[razzeee]

@phate89 how ready is this to go in?

[phate89]

I still need to look If I can do the changes requested by tolriq...

[Tolriq]

If the method is needed for other things, do not block for the ids.

Ids would be cool for remotes for genre and tags, but there's workaround, if this open things for Kodi internals or addons then let's use the workaround for remotes until maybe ids are added later.

[phate89]

rebased
@Tolriq adding ids to getdetails is not that easy because they're not parsed at all (they're stored as a list of strings right now both genres and tags)
So for now (finally) I want to get this pr in..
Do you have new comments/do you want to test it?

[Montellese]

Please fix the issue brought up by @Jalle19. Apart from that it looks good to me.

The only thing I've been wondering is if there's any sorting for tags that makes sense at all.

[Tolriq]

@phate89 nothing more from me if Id can not be returned from getMovies / Details:)

I can test if you want but for Yatse I won't use as it's faster to reconstruct the TAG data from getMovies than do another query that returns id that I can't use :(

But need a test build as there's the VS 2015 migration occurring and I'm still at 2013 until all is stable :)

[phate89]

@Montellese I left it like getgenres and the case is the same.. Should I drop sorting?

@Tolriq http://mirrors.kodi.tv/test-builds/win32/KodiSetup-20160405-08edc16-expose_tag_json.exe for testing

[Tolriq]

I know not the correct place bla bla :)

But addons\skin.re-touched is shipped with _screenshots folder + some git files + build.bat

• build is missing python27.dll

Except that, all works at JSON level.

But as a side note it's incredibly complicated now to find the file entry for video to create a musicvideo source. Specially with the file manager that is easy to access from main screen and will lead users to add sources there :(

[phate89]

rebased
@Montellese do I have to drop sorting field? I don't think there are options to sort tags but I'm not sure

[Montellese]

We can keep it for consistency but it's not much use.

[phate89]

jenkins build this please

[Montellese]

No objections from me.