dvdplayer: add a method to avoid requeting HTTP Header #7407
Conversation
|
thanks @FernetMenta had mostly forgotten about this after grooveshark died. |
|
I think it looks good, I generally don't like bool parameters as it's hard to know what they mean without looking up the definition, don't think it would be worth the work to go for a flag of some sort though. +1 from me. On a sidenote, shouldn't path param be changed to a string whenever someone gets around to it? |
| @@ -87,7 +87,8 @@ bool DVDPlayerCodec::Init(const std::string &strFile, unsigned int filecache) | |||
| return false; | |||
| } | |||
|
|
|||
| if (!m_pInputStream->Open(strFileToOpen.c_str(), m_strContentType)) | |||
| // TODO: XXX | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Rebase, maybe change the todo to what you said and go ahead and merge |
|
done |
|
jenkins build this please |
dvdplayer: add a method to avoid requeting HTTP Header
|
Sorry, can you elaborate more on this "I implemented it - but the users of this features don't want / need it anymore ... now SetMimeType seems to work by accident so their interest is zero ... and I don't care too much, just wanted to help them." ? Thank you |
|
In order to force dvdplayer to not doing head requests, we need a method that makes sure it does not do it. This needs integrating into python api, like: https://github.com/fritsch/xbmc/commits/pymaster cause SetMimeType is not what one wants to misuse for this. |
|
Thanks, just wanted to know if this is a feature that is still worked on. Unfortunately it is necessary for a handful of users still using crappy servers/stream providers... |
|
So - then. You are free to pick it up, test it and PR it. See it as a present from me to you :-) |
|
Thank you so much ! :-) Excuse my ignorance, is it already included in the nightlies ? |
|
No - I just wrote it. Find someone that understands it and picks it for you. I don't really care. |
This provides a means to instruct dvdplayer not to request HTTP header. dvdplayer clients pass a fileitem to dvdplayer::OpenFile. dvdplayer will use the information provided by fileItem (CFileItem::ContentLookup() ) to decode if further header requests will be done.