[gui] refactors modality handling for dialogs #7428
Conversation
xhaggi
added
the
Type: Improvement
xhaggi
force-pushed
the
refactor-dialog-modality
branch
2 times, most recently
from
cd7963b
to
d5c9376
Compare
|
Look good and clean to me. I wonder if there's a scenario where a dialog has to be called with a specific modality though. |
|
any other objections? @Paxxi or @Montellese |
xhaggi
force-pushed
the
refactor-dialog-modality
branch
from
d5c9376
to
217bc36
Compare
|
jenkins build this please |
|
@xhaggi I haven't gone through it in detail but I like the changes and cleanup and I think it's going in the right direction, 👍 |
|
ok i'm waiting for some feedback from @Montellese and if he's fine we should shove it in asap. |
| //send message and wait for user input | ||
| ThreadMessage tMsg = {TMSG_DIALOG_DOMODAL, WINDOW_DIALOG_YES_NO, g_windowManager.GetActiveWindow()}; | ||
| CApplicationMessenger::Get().SendMessage(tMsg, true); | ||
| pDialog->Open(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
As mentioned in the commit comment I'm not 100% sure about all the changes from (blocking) threaded messages to directly opening the dialog since it changes the thread in which the dialog is opened. But I also don't know the guilib code that well. |
|
apart from your comments any other objections? |
|
I don't think so. |
xhaggi
force-pushed
the
refactor-dialog-modality
branch
2 times, most recently
from
520bbc8
to
01e2dce
Compare
xhaggi
force-pushed
the
refactor-dialog-modality
branch
from
01e2dce
to
5252f1e
Compare
|
jenkins build this please |
[gui] refactors modality handling for dialogs
This PR refactors the modality handling of dialogs out of the methods
CGUIDialog::DoModalandCGUIDialog::Show. Now we specify the modality on a per dialog basis and the modality is not changed depending on the method call. Therefore I've dropped the methodsDoModalandShowand introduced a new methodCGUIDialog::Openas a replacement.@Montellese @mkortstiege @Paxxi mind taking a look.