Remove git clean usage from binary-addons rule #7473
Conversation
The usage of 'git clean' will wipe files belonging to the kodi source tree under the following conditions: - have a git controlled parent directory, like $HOME - have a work directory for kodi builds, like ~/rpmbuild - read docs/README.linux to grasp the required steps to get bin-addons - prepare kodi-master.tar and various addon.foo.tar with git archive - attempt to do an offline build, like rpmbuild -ba kodi.spec - in that kodi.spec do steps as outlined in section 4.4 of README.linux - running the commands will wipe everything in project/cmake/addons Steps to reproduce: $ mkdir $$ $ cd $_ $ git init $ mkdir kodi-version $ cd $_ $ mkdir project $ cd $_ $ touch a b c $ git clean -n -dfx Would remove a Would remove b Would remove c The fix for this (valid) setup is to always have a fixed list of files to remove and to not rely on git to do the wrong thing. Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
Hot spot here imo (looking to jenkins who relies on proper clean). Maybe @wsnipex or @Montellese have a comment for this. |
|
The git clean is there to make sure addons build correctly if you manually ran cmake to build addons before. I assume you are trying to package binary addons from inside the kodi tree. This is not how its meant to be done on linux. Every addon can be built standalone, you just need the kodi headers, kodi-config.cmake and cmake helpers installed. |
No, I dont. Thats not what this PR is all about. What I wrote is that 'git clean' is the wrong tool for the job. Just try to parse what I wrote. |
|
very well. I told you why git clean is there. If you want to come up with a comprehensive list of all possible files that need to be deleted, be my guest. Its every possible addon and its depends that might be in that dir. |
|
I agree with @olafhering. this cmd is way too dangerous in that script. |
|
For the time being I will leave this minefield alone. |
The usage of 'git clean' will wipe files belonging to the kodi source
tree under the following conditions:
Steps to reproduce:
$ mkdir $$
$ cd $_
$ git init
$ mkdir kodi-version
$ cd $_
$ mkdir project
$ cd $_
$ touch a b c
$ git clean -n -dfx
Would remove a
Would remove b
Would remove c
The fix for this (valid) setup is to always have a fixed list of
files to remove and to not rely on git to do the wrong thing.
Signed-off-by: Olaf Hering olaf@aepfle.de