Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set BICUBIC as default picture scaling algorithme #7549

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

MartijnKaijser
Copy link
Member

No description provided.

@un1versal
Copy link
Contributor

Would be extra nice to know what algorithm is in use via logging especially since the as.xml.

@MartijnKaijser MartijnKaijser added this to the J**** 16.0-alpha1 milestone Jul 20, 2015
MartijnKaijser added a commit that referenced this pull request Jul 21, 2015
set BICUBIC as default picture scaling algorithme
@MartijnKaijser MartijnKaijser merged commit 86ba9d3 into xbmc:master Jul 21, 2015
@MartijnKaijser MartijnKaijser deleted the bicubic branch July 21, 2015 06:54
@NedScott
Copy link
Contributor

@UniversaI wouldn't it show up in the log for the as.xml settings? If no as.xml settings are loaded then we can assume that this default is being used.

@un1versal
Copy link
Contributor

Sure its still an assumption, confirmation that and which is actually is in use would be ideal, but no biggie. I tried adding the logline for testing but had no luck finding the right place to put it or even the right log call.

@MartijnKaijser
Copy link
Member Author

there's no confirmation for many other settings that are changed with advancedsettings

@un1versal
Copy link
Contributor

I dont think that is right either, if someone overrides something and causes some issue or put a typo somewhere in advancedsettings and whoever is looking misses the typo then

Or even if something breaks that setting / override thers no way of knowing anything for sure.

My as.xml was set to override to bicubic and used texturecache.py to recache everything, not once did I see bicubic entry anywhere in log and if the override was working or not its an unknown. Would have been more comfortable knowing I didn't spend all that time reaching for nothing especially since a few images looked just as bad as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants