[win32] cmake: no need to check for install permissions (avoid creating unneeded directories) #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng unneeded directories)
Montellese
added
Type: Fix
|
looks good |
|
jenkins build this please |
Montellese
added a commit
that referenced
this pull request
Jul 20, 2015
[win32] cmake: no need to check for install permissions (avoid creating unneeded directories)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up an issue on Windows introduced by 98bf72d which added a check to see if cmake has the rights to write into the installation directory. On Windows this doesn't make any sense and results in creating directories in the installation directory which either end up in the installer (but they aren't installed) or in the
addonsdirectory during development resulting in some warning logs about addon directories without anaddon.xml.