[pvr][fix] users are trapped in the splash screen while start into a pvr window + no connection to backend

[xhaggi]

This happens if you choose a PVR window as startup window and Kodi can't connect to the PVR backend. You are trapped in the splash screen and you need to kill the app and your GUI settings to reset the startup window configuration. It happens because the PVR Manager will handle the activation of the startup window after it has been started, but this fails (no connected clients). This PR will remove the startup window activation stuff from the PVR manager and let CApplication handle it like it's done for every other window. To activate a PVR window only if the PVR manager has been started, i've introduced a busy dialog into CGUIWindowPVRBase and wait until the manager has been started. You are able to cancel the waiting process and you'll be returned to the previous window (usually the home window).

The mouse pointer issue is related to the splash window issue we already addressed with #7650.

@ksooo @Jalle19 mind taking a look and should we consider a backport?

[xhaggi]

I've pushed an alternative way (bases on progress dialog) to inform the user about the PVR manager startup if he enters a PVR window because the busy dialog can't display a message.

[xhaggi]

@ronie mind taking a look at the commit for confluence. We are able to specify if we want to display/hide the progressbar in the progress dialog with CGUIDialogProgress::ShowProgressBar(bool bOnOff) but confluence is missing the id attribute.

[phil65]

@xhaggi wouldnt DialogOK be more appropriate to display a short message or do you need the progress bar?

[xhaggi]

nope won't work because you can't specify what happen if you click on the ok button. And it will block the gfx render thread/lock gfx context which is a no-go too.

edit: to be clear what happens here - the progress dialog automatically disappear if the pvr manager is ready or you can interact and cancel the waiting process

[ksooo]

Not runtime-tested, but the code changes look reasonable to me. If I find the time I will do a runtime test tonight or during the weekend.

[xhaggi]

jenkins build this please

[ksooo]

Set TV as startup window, disabled tvheadend . Runtime tested. Crashes reliably :-( Crash log: http://paste.ubuntu.com/11975859/

[xhaggi]

thanks will take a look at it.

[xhaggi]

I can't really reproduce the issue. I wonder which version you run, because in master we don't have the method CGUIDialog::DoModal(int, std::string const&) anymore.

#0  0x0000000000cbafd8 in PVR::CGUIWindowPVRChannels::UpdateButtons() ()
#1  0x0000000000b2dae2 in CGUIMediaWindow::OnFilterItems(std::string const&) ()
#2  0x0000000000b2e474 in CGUIMediaWindow::Update(std::string const&, bool) ()
#3  0x0000000000cbaed5 in PVR::CGUIWindowPVRChannels::Update(std::string const&, bool) ()
#4  0x0000000000b2ad14 in CGUIMediaWindow::Refresh(bool) ()
#5  0x0000000000b314f6 in CGUIMediaWindow::OnMessage(CGUIMessage&) ()
#6  0x0000000000cbb365 in PVR::CGUIWindowPVRChannels::OnMessage(CGUIMessage&) ()
#7  0x00000000008629b7 in CGUIWindowManager::SendMessage(CGUIMessage&) ()
#8  0x0000000000862c4e in CGUIWindowManager::DispatchThreadMessages() ()
#9  0x0000000000b4a054 in CApplication::Process() ()
#10 0x00000000008614ec in CGUIWindowManager::ProcessRenderLoop(bool) ()
#11 0x0000000000880ee2 in CGUIDialog::DoModal_Internal(int, std::string const&) ()
#12 0x0000000000880a21 in CGUIDialog::DoModal(int, std::string const&) ()
#13 0x0000000000cb8821 in PVR::CGUIWindowPVRBase::OnInitWindow() ()

[ksooo]

Latest 15.1 which the PR backport.

[xhaggi]

could you please try the master.

[ksooo]

Look at the crashing method. It seems to access PVR stuff that is not yet available at that moment?

for me, the crash occurs not sporadically, but on every startup.

[xhaggi]

sure we can check for if (g_PVRManager.IsStarted()) in UpdateButtons() and return if not started. But i want to know if it also occurs on master.

[xhaggi]

we need to know which message is triggered in CApplication::Process() this message refresh the list :/

[ksooo]

I do very sorry. I have no time today.

[xhaggi]

np, let me know if you found time. have a nice day 😎

[ksooo]

Just a short update (will be offline after writing until late night/tomorrow ;-) Happens also on master, same callstack. Crash gets caused here: https://github.com/xbmc/xbmc/blob/master/xbmc/windows/GUIMediaWindow.cpp#L337 No idea though, why message GUI_MSG_REMOVED_MEDIA is generated on startup. I definitely do not remove any media myself on startup. ;-)

[xhaggi]

thanks for the investigation. that explain why i can't reproduce the issue. we neee to protect the update method and do a earlier return if pvr manager is not started. this should fix it.

[xhaggi]

@ksooo I've pushed a new commit which will protect the pvr windows against illegal gui messages if the manager is not started. It would be nice if you take a look and do some tests thanks ;)

[ksooo]

Confirming that it works now.

Another story is that I find the dialog in front of the half populated PVR window is very ugly. See @xhaggi's screenshot. It really looks exactly like this while one is waiting for PVR to get ready. But as I have no ides how to do it better, I'd rather shut up, I guess.

[xhaggi]

@ksooo better as trapped in the splash and you can't interrupt it ;)

jenkins build this please

[xhaggi]

is blocked by #7667

[xhaggi]

jenkins build and merge