[guilib] mouse wheel scrolling on spin and slider controls #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l spinners are focused
…l slider is focused
|
This has bothered me for a long time, +1 for the change |
xhaggi
added
the
Type: Improvement
|
looks good +1 |
|
+1. I would even +1 to remove changing settings via mousewheel completely, but this one also is fine to me. |
|
jenkins build this please |
|
Since this is changing mouse behavior and i am not really using the mouse to control Kodi, i'd like to get some more comments before merging. /cc @da-anda, @MartijnKaijser, @Montellese |
|
never used the mouse myself, but change sounds reasonable from your description. |
MartijnKaijser
added a commit
that referenced
this pull request
Aug 4, 2015
[guilib] mouse wheel scrolling on spin and slider controls
|
@mkortstiege could this be considered for a backport? Seems like a usability issue that has been solved now |
Merged
|
Backport @ #7767. Since it's not a real fix and i am not using the mouse, I have no strong opinion on this one ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way we're handling mouse wheel scrolling for spin and slider controls. Currently we're scrolling through the actual values whenever the pointer is in the hit rect of the given control. This commits changes it to just scroll when the actual spin or slider (not the entire button) is under the pointer.
Not sure if this is the intended and wanted behavior, so please comment.