[input] fix stack overflow in HasLongpressMapping

[xhaggi]

@FernetMenta @koying let's move the discussion to this PR.

[xhaggi]

@koying i've added a separate commit for what you've suggested, return -1 in case GetFallbackWindow is called with WINDOW_ADDON_START

[koying]

If you go my route, you also have to change

xbmc/xbmc/addons/AddonCallbacksGUI.cpp

Line 295 in 943c92e

int id = WINDOW_ADDON_START;

to "+1" and you might need to rework

xbmc/xbmc/input/ButtonTranslator.cpp

Line 1045 in 943c92e

int fallbackWindow = GetFallbackWindow(window);

But that probably deserves a separate PR. I suggest to do a plain fix here and think further about making GetFallbackWindow more coherent.

[xhaggi]

I've squashed both commits together because the fix only works if both are applied.

[FernetMenta]

@xhaggi I only have a MacBook with me and can't test until coming Monday. Thanks for looking into this.

[xhaggi]

@FernetMenta does it crash if you open an addon window and press a key?

[FernetMenta]

@xhaggi yes, it crashed as soon as I pressed a key when an addon window was opened.

[xhaggi]

Thought i can test it but don't find an addon window 😄 and do not have vdr ready.

[FernetMenta]

ADSP uses addon windows too. @AchimTuran are there any ADSP addons ready for testing?

[xhaggi]

@FernetMenta do you know a reason why we do this special handling in GetFallbackWindow for addon window ids but not for our python addon window ids?

[FernetMenta]

@xhaggi I think python windows have not had the requirement so far. I implemented it for addon windows because I had the requirement to define key-action mappings for those.

[xhaggi]

Thanks for the explanation :)

[FernetMenta]

@xhaggi I am sure there is much room for improvement. At the time I did this I resurrected addon windows that were decayed and not usable.
Ideally an addon should be able to bring its own key-action mapping like it can bring its own skin files. What do you think?

[AchimTuran]

@FernetMenta

ADSP uses addon windows too. @AchimTuran are there any ADSP addons ready for testing?
You can use adsp.basic, adsp.freesurround or adsp.biquad.filters.

Hopefully they will compile. But in two weeks I will have some time to fix them.

[FernetMenta]

@xhaggi seems to fix the issue

[xhaggi]

jenkins build and merge

[koying]

Addons building is failing. unrelated.

[stefansaraev]

@xhaggi well.. this completely breaks longpress for me.

[xhaggi]

could you please explain what's broken?

[stefansaraev]

impossible to use long press. short press action immediately executed, log spammed http://sprunge.us/YOZg.

after reverting: http://sprunge.us/CdKc