Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video] replace play stack selection dialog with select dialog #7876

Merged
merged 2 commits into from Sep 1, 2015

Conversation

mkortstiege
Copy link
Member

Yet another dialog nuke PR. This nukes the play stack selection dialog in favor of the generic select one.

Before:
screenshot from 2015-08-23 20 03 22

After:
screenshot from 2015-08-23 20 04 58

/cc @phil65, @ronie

@mkortstiege mkortstiege added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality labels Aug 23, 2015
@phil65
Copy link
Contributor

phil65 commented Aug 23, 2015

+1, nice.

@ronie
Copy link
Member

ronie commented Aug 23, 2015

always hated that fugly dialog.

nuke! nuke! nuke!

@MartijnKaijser
Copy link
Member

may i also add that the header text is also bit weird

@mkortstiege
Copy link
Member Author

Updated. Changed the dialog header to Play part ... (same as the context menu action that triggers it).

@MartijnKaijser MartijnKaijser added this to the Jarvis 16.0-alpha3 milestone Aug 23, 2015
mkortstiege added a commit that referenced this pull request Sep 1, 2015
[video] replace play stack selection dialog with select dialog
@mkortstiege mkortstiege merged commit f69ccef into xbmc:master Sep 1, 2015
@mkortstiege mkortstiege deleted the nuke-dialog-filestack branch October 6, 2015 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants