Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binary addons] fix android by using TARGET_LINKER_FILE_NAME instead of TARGET_FILE_NAME #7885

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Projects
None yet
3 participants
@Montellese
Copy link
Member

Montellese commented Aug 24, 2015

Right now binary addons on android are broken because the used TARGET_FILE_NAME generator returns the binary addon's library file name with the trailing version number which is not supported on android. Therefore we need to use the TARGET_LINKER_FILE_NAME generator for android.

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Aug 24, 2015

@wsnipex: Is this ok for you? jenkins build this please

@wsnipex

This comment has been minimized.

Copy link
Member

wsnipex commented Aug 25, 2015

looks fine, thanks

wsnipex added a commit that referenced this pull request Aug 25, 2015

Merge pull request #7885 from Montellese/binary_addons_fix_droid
[binary addons] fix android by using TARGET_LINKER_FILE_NAME instead of TARGET_FILE_NAME

@wsnipex wsnipex merged commit f8be3c3 into xbmc:master Aug 25, 2015

1 check passed

default Merged build finished.
Details

@Montellese Montellese deleted the Montellese:binary_addons_fix_droid branch Aug 25, 2015

@hudokkow hudokkow added this to the Jarvis 16.0-alpha2 milestone Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.