[binary addons] fix android by using TARGET_LINKER_FILE_NAME instead of TARGET_FILE_NAME #7885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of TARGET_FILE_NAME
|
@wsnipex: Is this ok for you? jenkins build this please |
|
looks fine, thanks |
wsnipex
added a commit
that referenced
this pull request
Aug 25, 2015
[binary addons] fix android by using TARGET_LINKER_FILE_NAME instead of TARGET_FILE_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now binary addons on android are broken because the used
TARGET_FILE_NAMEgenerator returns the binary addon's library file name with the trailing version number which is not supported on android. Therefore we need to use theTARGET_LINKER_FILE_NAMEgenerator for android.