TexturePacker: some cleanup and win32 buildsystem fixes #7961
Conversation
Montellese
added
Type: Fix
|
yw. Question: Isnt Texturepacker able to compile independently from Kodi? Also once this goes in a new build (would be nice) should be uploaded to mirror so that all fixes and version is in. |
|
It can't compile independently from Kodi because it shares some source files as well. But those don't have to be pre-built. I never checked the other dependencies but I guess they have to be there already as well. |
|
Well since I never compiled Kodi here, So with some certainty can claim only squish seems to be required to be built previously to compiling texturepacker. Not a big deal but good to know. Thx. |
|
jenkins build this please |
| std::string path = file.GetPath(); | ||
| char pathMem[CXBTFFile::MaximumPathLength]; | ||
| memset(pathMem, 0, sizeof(pathMem)); | ||
|
|
||
| for (std::string::iterator ch = path.begin(); ch != path.end(); ++ch) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Montellese
force-pushed
the
fix_texturepacker_win32
branch
from
afa26f4
to
c3df968
Compare
|
I've expanded the comment on how to write the path into the XBT file as requested by @Paxxi. jenkins build this please |
|
How do we want to handle this with the prebuilt win32 version? We can't update the already uploaded archive with the 1.0.3 version. We can either bump the version to 1.0.4 in the project file and upload a new package with that version or leave the version at 1.0.3 (as fixed by this PR) and upload a new package with 1.0.3-1. @MartijnKaijser preferences? |
|
just bump it as that makes most sense. |
Montellese
force-pushed
the
fix_texturepacker_win32
branch
from
c3df968
to
2b23da8
Compare
|
Bumped to 1.0.4 but the package is missing (can't upload right now). Will do later and then merge. |
Montellese
force-pushed
the
fix_texturepacker_win32
branch
from
2b23da8
to
96f9d6d
Compare
|
jenkins build and merge |
This replaces #7839 (thanks @UniversaI) and adds two additional (non-critical) fixes to the TexturePacker. The first commit makes sure that running TexturePacker multiple times with the same input always produces the same output. The second commit fixes the debug build configuration in the VS solution.