[guilib] The output buffer of IImage::Decode should be a const pointe… #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Paxxi ping |
|
missed a few in xbmc/cores/omxplayer/OMXImage.cpp and xbmc/cores/omxplayer/OMXImage.h |
|
Thx, but that's not an iimages. jenkins build this please |
| @@ -42,7 +42,7 @@ class CJpegIO : public IImage | |||
| static bool CreateThumbnailFromSurface(unsigned char* buffer, unsigned int width, unsigned int height, unsigned int format, unsigned int pitch, const std::string& destFile); | |||
| void Close(); | |||
| // methods for the imagefactory | |||
| virtual bool Decode(const unsigned char *pixels, unsigned int pitch, unsigned int format); | |||
| virtual bool Decode(unsigned char* const pixels, unsigned int pitch, unsigned int format); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good, go ahead and merge |
…r rather than a pointer to a const value.
ace20022
force-pushed
the
decode_const
branch
from
d72e4c8
to
57ace89
Compare
ace20022
added a commit
that referenced
this pull request
Sep 7, 2015
[guilib] The output buffer of IImage::Decode should be a const pointe…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r rather than a pointer to a const value.
Found because of @Paxxi ;)