Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] remove no more needed libmp3lame #7974

Merged
merged 1 commit into from
Sep 7, 2015

Conversation

AlwinEsch
Copy link
Member

Found during creation of my multi platform system a fault with libmp3lame on i386 system which becomes called from ./tools/buildsteps/linux32/make-depends.

Also reported here on debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760047

Has included the needed fix patches to the addon on xbmc/audioencoder.lame#10 and can be removed now here as dependency.

@FernetMenta
Copy link
Contributor

why not dropping this lib? if I am not mistaken it is not used by the application.

@AlwinEsch
Copy link
Member Author

Has not direct reviewed the use of them, you are right not used anymore inside kodi itself.

I check the audioencoder.lame add-on build now without the library present.

@FernetMenta
Copy link
Contributor

I check the audioencoder.lame add-on build now without the library present.

if this addon requires the lib, it should be moved to the addon

@stefansaraev
Copy link
Contributor

it's already moved.
https://github.com/xbmc/audioencoder.lame/blob/master/depends/common/lame/CMakeLists.txt

libmp3lame should be safe to be removed from depends

@AlwinEsch AlwinEsch changed the title [depends] fix libmp3lame i386 compile errors [depends] remove no more needed libmp3lame Sep 6, 2015
@AlwinEsch
Copy link
Member Author

Is updated and libmp3lame removed from depends.
The previous patches are now included on add-on itself.

jenkins build this please.

binary-addons https://github.com/AlwinEsch/repo-binary-addons.git master

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@AlwinEsch
Copy link
Member Author

Is removed

AlwinEsch added a commit that referenced this pull request Sep 7, 2015
[depends] remove no more needed libmp3lame
@AlwinEsch AlwinEsch merged commit 02b371a into xbmc:master Sep 7, 2015
@AlwinEsch AlwinEsch deleted the fix-mp3-lame-i386 branch September 7, 2015 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants