-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[depends] remove no more needed libmp3lame #7974
Conversation
why not dropping this lib? if I am not mistaken it is not used by the application. |
Has not direct reviewed the use of them, you are right not used anymore inside kodi itself. I check the audioencoder.lame add-on build now without the library present. |
if this addon requires the lib, it should be moved to the addon |
it's already moved. libmp3lame should be safe to be removed from depends |
ab1a2a2
to
fa454b0
Compare
fa454b0
to
cebf7df
Compare
Is updated and libmp3lame removed from depends. jenkins build this please. |
binary-addons https://github.com/AlwinEsch/repo-binary-addons.git master |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
b1ee53d
to
cebf7df
Compare
Is removed |
[depends] remove no more needed libmp3lame
Found during creation of my multi platform system a fault with libmp3lame on i386 system which becomes called from ./tools/buildsteps/linux32/make-depends.
Also reported here on debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760047
Has included the needed fix patches to the addon on xbmc/audioencoder.lame#10 and can be removed now here as dependency.