-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xbmc] Add missing include of <utility> #7975
Conversation
jenkins build this please |
bb654fb
to
b867edb
Compare
ok test again without cstdlib changes |
I always keep system includes at the top trying to follow the C++ Google Coding Guidelines. |
@Montellese I did that as well until recently. The issue with it that I can see is that it hides missing includes in the headers Lib.h
Lib.cpp
User.cpp
|
Seems like the google guidelines sticks them somewhat in the middle |
Yeah they put the include of the header belonging to the source file at the very top followed by C system includes, C++ system includes and then local includes. |
That style is fine by me, I'll update this |
3f89466
to
d3efae4
Compare
so updated to google style include, broke pvr by reordering includes so there's some forward declarations and new includes added. |
d3efae4
to
9a3151b
Compare
jenkins build this please |
9a3151b
to
66e117b
Compare
jenkins build this please |
66e117b
to
ff652b3
Compare
jenkins build and merge this please |
This is a bit oppinionated, moved system includes to the bottom to try and avoid masking missing includes.
ff652b3
to
7610501
Compare
jenkins build and merge this please |
you would do me favour if you refrained from doing cosmetics in core. it is really painful rebasing VideoPlayer on this. |
sorry about that @FernetMenta I'm done with these major clean-ups now for a while so should hopefully not cause you any more pain. |
This is a bit oppinionated, moved system includes to the bottom to try and avoid masking missing includes.