New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[strings] DTS -DTS-HD settings description, include relationship to DCADEC setting. #7984
Conversation
I would shorten the text: Select this option if your receiver is capable of decoding DTS streams. Note: Enabling this option will disable eight-channel DTS-HD audio decoding". instead of: Select this option if your receiver is capable of decoding DTS-HD streams. Note: Current users that have this option enabled, wont be able to enable option for "Support 8 channel DTS-HD audio decoding". |
I agree with @garbear - especially the "Current users that..." definetly has to go. In order to keep the reference to the settings label we could try |
Cant read like that, this is specific to current users who will upgrade Kodi, and now suddenly see this new option (in disabled state) since they already have DTS/ DTS-HD passthrough enabled, You also cannot enable that without disabling the already set passthrough, what you suggest is not right for current users who dont clean install. You guys are not realizing (if you already have DTS and DTS-HD passthrough enabled) you cannot read the new setting description OR enable it if you upgrade Kodi. What you suggest is OK for new users, current users are still left with some illogical description since they DONT have that option enabled and for them that settings is already described appropriately. |
read again. Your suggestion is not acceptable with the "Current users" stuff in, as this is not suiteable for a settings description but rather sounds like a wiki page or upgrade instructions. The settings description is NO upgrade instruction and thus must be written in a generic way that simply states that using passthrough will disable the decoding option. Phrasing could probably be improved, but it must not be written like a upgrade instruction as it is none. |
Im open to suggestions on wording but the previously suggested doesnt seem great either and Im not writing a wiki page at this time, eventually maybe it will exist. Perhaps Note: Disable this option if you wish to enable, "Support 8 channel DTS-HD audio decoding"." |
Updated description |
55aed69
to
802a461
Compare
@da-anda Done as you suggested exactly. |
[strings] DTS -DTS-HD settings description, include relationship to DCADEC setting.
Following addition of DCADEC. @jjd-uk @da-anda
Description reads:
Enables decoding of high quality DTS-HD audio streams. Note: This increases CPU load and is only available when DTS and DTS-HD audio passthrough are disabled.
The problem is that existent users that only upgrade Kodi and already have a their audio passthough enabled, will see this new option on settings but cant enable it or read its settings description, since this new option is conditional of DTS and DTS-HD being disabled.
New users dont have this problem since by default passthrough is disabled, but since we cant reset everyone's settings, this is the sane and logical thing to do is to add a note to passthough descriptions to tell current users they aren't going mad and what is going on.