[videodb] Add support for overview (plot) in movie sets. #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good apart from the minors. |
|
@anaconda see http://forum.kodi.tv/showthread.php?tid=181318 Will link this PR there since its related. |
|
Thanks for your review. I have added 2 fixup commits to address your comments. |
anaconda
force-pushed
the
sets-overview
branch
2 times, most recently
from
b9ffeaa
to
7542ccd
Compare
|
It's possible to add also an additional node to predefine "sort by year" or "sort by title" (year = 0 / title = 1)? |
anaconda
force-pushed
the
sets-overview
branch
from
7542ccd
to
86a65dd
Compare
| @@ -4602,11 +4631,16 @@ void CVideoDatabase::UpdateTables(int iVersion) | |||
| m_pDS->exec("ALTER TABLE tvshow ADD userrating integer"); | |||
| m_pDS->exec("ALTER TABLE musicvideo ADD userrating integer"); | |||
| } | |||
|
|
|||
| if (iVersion < 97) | |||
| { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good apart from the minor. |
added 2 commits
September 20, 2015 14:45
Makes it possible to specify an overview/plot in movies sets.
Skins can retrieve it via ListItem.Plot (in fact Confluence doesn't need any
modification - "set overview" will be shown where the plot for movies is).
This changes the format of the <set> tag for movie NFO files.
Current:
<set>My movie set</set>
Proposed:
<set>
<name>My movie set</name>
<overview>This is my awesome movie set.</overview>
</set>
The <overview> tag is optional, and the current format will still be supported
to not break existing scrapers or local NFO files.
See:
* http://forum.kodi.tv/showthread.php?tid=237761
* https://www.themoviedb.org/collection/121938-the-hobbit-collection
(API does provide the "overview".)
anaconda
force-pushed
the
sets-overview
branch
from
86a65dd
to
6c969e7
Compare
|
jenkins build and merge |
jenkins4kodi
added a commit
that referenced
this pull request
Sep 20, 2015
jester-xbmc
added a commit
to jester-xbmc/skin.amber
that referenced
this pull request
Jan 14, 2016
Includes_Variables: show plot for movie sets (Jarvis feature). xbmc/xbmc#8013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to specify an overview/plot in movies sets.
Skins can retrieve it via ListItem.Plot (in fact Confluence doesn't need any
modification - "set overview" will be shown where the plot for movies is).
This changes the format of the
<set>tag for movie NFO files.Current:
Proposed:
The
<overview>tag is optional, and the current format will still be supportedto not break existing scrapers or local NFO files.
See:
(API does provide the "overview".)