AML: EGLNativeTypeAmlAndroid: Implement 480cvbs/i/p and 576cvbs/i/p modes #8017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. jenkins build and merge |
|
Yeah, tested and working good. But as I said, problems with devices that connect to TV with component output might have issues on low resolutions. Component is up to 720p but if lower, might be issue because no hdmi connected (function that checks it will return false). |
|
Well, nobody I know still has component, so that at least give them a chance ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix video size issues on 720x480 (NTSC) and 720x576 (PAL) too. What I was not able to test is 480i/p/576i/p on device with component output (when hdmi is not connected but component is) because I don't have any device with component output 😄 )