Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[pvr] changed: also use CACHESTATE_PVR in dvdplayer when play… #8022

Merged
merged 1 commit into from
Sep 12, 2015

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 11, 2015

…ing a recording that's still running"

This reverts commit 78901e2.

As discussed here: #7905 (comment)

@Glenn-1990 mind testing this?

…ing a recording that's still running"

This reverts commit 78901e2.
@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v15 Isengard labels Sep 11, 2015
@ksooo
Copy link
Member Author

ksooo commented Sep 11, 2015

jenkins build this please

@Glenn-1990
Copy link
Contributor

@ksooo, Yes this seems to do the job, thanks :-)

@Jalle19
Copy link
Member

Jalle19 commented Sep 11, 2015

@ksooo please add "fixes #16141" to the commit message so the bug report gets closed.

@ksooo
Copy link
Member Author

ksooo commented Sep 11, 2015

@ksooo please add "fixes #16141" to the commit message so the bug report gets closed.

No, sure about this as we're reverting only on Isengard branch, not on master. There, the bug will still exist after this PR got merged. With this, I don't think it is a good idea to close the bug report.

ksooo added a commit that referenced this pull request Sep 12, 2015
Revert "[pvr] changed: also use CACHESTATE_PVR in dvdplayer when play…
@ksooo ksooo merged commit 667a80b into xbmc:Isengard Sep 12, 2015
@ksooo ksooo deleted the isengard-partially-revert-pr6566 branch September 12, 2015 10:54
@MartijnKaijser MartijnKaijser added this to the Isengard 15.2 milestone Sep 13, 2015
@Jalle19
Copy link
Member

Jalle19 commented Sep 13, 2015

@ksooo you're totally right. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v15 Isengard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants