Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][udf] Free allocated memory in the destructor. #8036

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

ace20022
Copy link
Member

No description provided.

@ace20022 ace20022 added the Type: Fix non-breaking change which fixes an issue label Sep 13, 2015
@ace20022
Copy link
Member Author

@MartijnKaijser does this qualify for a backport?

@MartijnKaijser
Copy link
Member

think so if it fixes the problem. Though you would have to play a lot of blurays for it to become a problem right?

@ace20022
Copy link
Member Author

think so if it fixes the problem. Though you would have to play a lot of blurays for it to become a problem right?

IIRC 1000 (or 100) times Sintel iso leads to ~200 mb.

But your decision, I'm not very interested in the old branch.

@MartijnKaijser
Copy link
Member

yeah just leave old behind us :)

@ace20022
Copy link
Member Author

jenkins build this please

@fritsch
Copy link
Member

fritsch commented Sep 13, 2015

If this fixes the issue and helps to save 200 MB when playing a single iso
and you consider this a fix, please backport.

It is worth it.

2015-09-13 20:56 GMT+02:00 Martijn Kaijser notifications@github.com:

yeah just leave old behind us :)


Reply to this email directly or view it on GitHub
#8036 (comment).

               Key-ID:     0x1A995A9B
               keyserver: pgp.mit.edu

Fingerprint: 4606 DA19 EC2E 9A0B 0157 C81B DA07 CF63 1A99 5A9B

@mkortstiege
Copy link
Member

jenkins build and merge. Please backport ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants